build/android/pylib/instrumentation/test_runner_test.py - Issue 669573003: Reland of 'New run shell implementation for DeviceUtils'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/test_runner_test.py

Issue 669573003: Reland of 'New run shell implementation for DeviceUtils' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better error handling when return code is not found Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/instrumentation/test_runner_test.py

diff --git a/build/android/pylib/instrumentation/test_runner_test.py b/build/android/pylib/instrumentation/test_runner_test.py

index 1a2b40f29aaf8a3cbf96d66cafcc522caf7ef0e8..039bb031ad63e0dcf76bafad32e7bcc40389f44a 100755

--- a/build/android/pylib/instrumentation/test_runner_test.py

+++ b/build/android/pylib/instrumentation/test_runner_test.py

@@ -261,8 +261,8 @@ class InstrumentationTestRunnerTest(unittest.TestCase):

self.instance._RunTest('test.package.TestClass#testMethod', 100)

self.instance.device.RunShellCommand.assert_called_with(

['am', 'instrument', '-r',

- '-e', 'test_arg_key', "'test_arg_value'",

- '-e', 'class', "'test.package.TestClass#testMethod'",

+ '-e', 'test_arg_key', 'test_arg_value',

+ '-e', 'class', 'test.package.TestClass#testMethod',

'-w', 'test.package/MyTestRunner'],

timeout=100, retries=0)

« build/android/pylib/device/adb_wrapper.py ('K') | « build/android/pylib/instrumentation/test_runner.py ('k') | no next file » | no next file with comments »