Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 669553002: Remove <marquee> leftovers (Closed)

Created:
6 years, 2 months ago by Timothy Loh
Modified:
6 years, 2 months ago
Reviewers:
haraken, apavlov, pfeldman
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, blink-layers+watch_chromium.org, caseq+blink_chromium.org, malch+blink_chromium.org, blink-reviews-css, yurys+blink_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, rwlbuis, loislo+blink_chromium.org, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, sergeyv+blink_chromium.org, andersr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove <marquee> leftovers This patch removes the various leftovers of the original marquee implementation: - RenderObject::isMarquee - StyleMarqueeData - -internal-marquee-* - EMarquee* TBR=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184259

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -371 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -97 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 2 chunks +4 lines, -26 lines 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 1 chunk +7 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 chunks +3 lines, -16 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 3 chunks +9 lines, -13 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 4 chunks +0 lines, -16 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -5 lines 0 comments Download
D Source/core/rendering/style/StyleMarqueeData.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/rendering/style/StyleMarqueeData.cpp View 1 chunk +0 lines, -54 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSMetadata.js View 4 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Timothy Loh
This is a rebased/updated version of https://codereview.chromium.org/629143005/ which also includes the other leftovers.
6 years, 2 months ago (2014-10-20 01:50:47 UTC) #2
haraken
LGTM!
6 years, 2 months ago (2014-10-20 02:02:50 UTC) #3
Timothy Loh
pfeldman: PTAL for a touched file in devtools
6 years, 2 months ago (2014-10-21 13:50:54 UTC) #4
Timothy Loh
+apavlov for a small change in devtools
6 years, 2 months ago (2014-10-22 23:48:41 UTC) #6
haraken
On 2014/10/22 23:48:41, Timothy Loh wrote: > +apavlov for a small change in devtools I ...
6 years, 2 months ago (2014-10-23 00:38:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669553002/20001
6 years, 2 months ago (2014-10-23 10:23:34 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 12:16:01 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184259

Powered by Google App Engine
This is Rietveld 408576698