Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 669543002: Fix auto-bisect presubmit so that it checks config files again. (Closed)

Created:
6 years, 2 months ago by qyearsley
Modified:
6 years, 2 months ago
Reviewers:
tonyg
CC:
chromium-reviews, Sergiy Byelozyorov, prasadv, RobertoCN
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix auto-bisect presubmit so that it checks config files again. When I changed this PRESUBMIT.py in http://crrev.com/292434, I didn't properly test it, so it hasn't actually been checking auto_bisect/bisect.cfg as it was supposed to. This change makes so that the files listed in the CONFIG_FILES list here will be checked (including run-perf-test.cfg, even though it's outside of the auto_bisect directory). BUG= Committed: https://crrev.com/6d0d8be56f7af030eb3eeff25861b8ff2258ca2c Cr-Commit-Position: refs/heads/master@{#300598}

Patch Set 1 #

Patch Set 2 : Fix auto-bisect presubmit so that it checks config files again. #

Patch Set 3 : Always check all config files (since run-perf-test.cfg apparently isn't in input_api.AffectedFiles(… #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M tools/auto_bisect/PRESUBMIT.py View 1 2 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qyearsley
6 years, 2 months ago (2014-10-20 16:25:48 UTC) #2
tonyg
lgtm
6 years, 2 months ago (2014-10-20 18:23:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669543002/60001
6 years, 2 months ago (2014-10-21 23:17:49 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-22 01:13:31 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:04:43 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6d0d8be56f7af030eb3eeff25861b8ff2258ca2c
Cr-Commit-Position: refs/heads/master@{#300598}

Powered by Google App Engine
This is Rietveld 408576698