Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 66953009: Web Animations CSS: Fix DocumentTimeline::numberOfActiveAnimationsForTesting() (Closed)

Created:
7 years, 1 month ago by Steve Block
Modified:
7 years, 1 month ago
Reviewers:
dstockwell, rjwright
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Web Animations CSS: Fix DocumentTimeline::numberOfActiveAnimationsForTesting() This is used by internals.numberOfActiveAnimations() in DRT and is part of the reason for the failure in repeated-firing-background-color.html Also beef up animation-controller-drt-api.html to test this fix. R=rjwright Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162182

Patch Set 1 #

Patch Set 2 : Fix const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -35 lines) Patch
M LayoutTests/animations/animation-controller-drt-api.html View 5 chunks +15 lines, -32 lines 0 comments Download
M LayoutTests/animations/animation-controller-drt-api-expected.txt View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/animation/DocumentTimeline.cpp View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Steve Block
7 years, 1 month ago (2013-11-18 00:28:47 UTC) #1
dstockwell
lgtm
7 years, 1 month ago (2013-11-18 05:47:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/66953009/30001
7 years, 1 month ago (2013-11-18 05:47:47 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 07:29:44 UTC) #4
Message was sent while issue was closed.
Change committed as 162182

Powered by Google App Engine
This is Rietveld 408576698