Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: media/filters/ffmpeg_demuxer.cc

Issue 66953005: Remove media::BindToLoop() in favour of media::BindToCurrentLoop(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix cros Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/ffmpeg_demuxer.cc
diff --git a/media/filters/ffmpeg_demuxer.cc b/media/filters/ffmpeg_demuxer.cc
index ae0d60411be175619d99ec901a71be39e071ab9b..a87bd371a1d7523402fe5b3532bbdc053eddca83 100644
--- a/media/filters/ffmpeg_demuxer.cc
+++ b/media/filters/ffmpeg_demuxer.cc
@@ -365,8 +365,6 @@ FFmpegDemuxer::FFmpegDemuxer(
audio_disabled_(false),
text_enabled_(false),
duration_known_(false),
- url_protocol_(data_source, BindToLoop(task_runner_, base::Bind(
- &FFmpegDemuxer::OnDataSourceError, base::Unretained(this)))),
need_key_cb_(need_key_cb) {
DCHECK(task_runner_.get());
DCHECK(data_source_);
@@ -376,7 +374,7 @@ FFmpegDemuxer::~FFmpegDemuxer() {}
void FFmpegDemuxer::Stop(const base::Closure& callback) {
DCHECK(task_runner_->BelongsToCurrentThread());
- url_protocol_.Abort();
+ url_protocol_->Abort();
data_source_->Stop(BindToCurrentLoop(base::Bind(
&FFmpegDemuxer::OnDataSourceStopped, weak_this_,
BindToCurrentLoop(callback))));
@@ -432,7 +430,9 @@ void FFmpegDemuxer::Initialize(DemuxerHost* host,
// see http://crbug.com/122071
data_source_->set_host(host);
- glue_.reset(new FFmpegGlue(&url_protocol_));
+ url_protocol_.reset(new BlockingUrlProtocol(data_source_, BindToCurrentLoop(
+ base::Bind(&FFmpegDemuxer::OnDataSourceError, base::Unretained(this)))));
+ glue_.reset(new FFmpegGlue(url_protocol_.get()));
AVFormatContext* format_context = glue_->format_context();
// Disable ID3v1 tag reading to avoid costly seeks to end of file for data we
@@ -662,7 +662,7 @@ void FFmpegDemuxer::OnFindStreamInfoDone(const PipelineStatusCB& status_cb,
duration_known_ = (max_duration != kInfiniteDuration());
int64 filesize_in_bytes = 0;
- url_protocol_.GetSize(&filesize_in_bytes);
+ url_protocol_->GetSize(&filesize_in_bytes);
bitrate_ = CalculateBitrate(format_context, max_duration, filesize_in_bytes);
if (bitrate_ > 0)
data_source_->SetBitrate(bitrate_);
« media/base/android/media_source_player_unittest.cc ('K') | « media/filters/ffmpeg_demuxer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698