Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Side by Side Diff: media/base/bind_to_loop_unittest.cc

Issue 66953005: Remove media::BindToLoop() in favour of media::BindToCurrentLoop(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix cros Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/bind_to_loop.h" 5 #include "media/base/bind_to_loop.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/synchronization/waitable_event.h" 8 #include "base/synchronization/waitable_event.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 20 matching lines...) Expand all
31 } 31 }
32 32
33 void BoundIntegersSet(int* a_var, int* b_var, int a_val, int b_val) { 33 void BoundIntegersSet(int* a_var, int* b_var, int a_val, int b_val) {
34 *a_var = a_val; 34 *a_var = a_val;
35 *b_var = b_val; 35 *b_var = b_val;
36 } 36 }
37 37
38 // Various tests that check that the bound function is only actually executed 38 // Various tests that check that the bound function is only actually executed
39 // on the message loop, not during the original Run. 39 // on the message loop, not during the original Run.
40 class BindToLoopTest : public ::testing::Test { 40 class BindToLoopTest : public ::testing::Test {
41 public:
42 BindToLoopTest() : proxy_(loop_.message_loop_proxy()) {}
43
44 protected: 41 protected:
45 base::MessageLoop loop_; 42 base::MessageLoop loop_;
46 scoped_refptr<base::SingleThreadTaskRunner> proxy_;
47 }; 43 };
48 44
49 TEST_F(BindToLoopTest, Closure) { 45 TEST_F(BindToLoopTest, Closure) {
50 // Test the closure is run inside the loop, not outside it. 46 // Test the closure is run inside the loop, not outside it.
51 base::WaitableEvent waiter(false, false); 47 base::WaitableEvent waiter(false, false);
52 base::Closure cb = BindToLoop(proxy_, base::Bind( 48 base::Closure cb = BindToCurrentLoop(base::Bind(
53 &base::WaitableEvent::Signal, base::Unretained(&waiter))); 49 &base::WaitableEvent::Signal, base::Unretained(&waiter)));
54 cb.Run(); 50 cb.Run();
55 EXPECT_FALSE(waiter.IsSignaled()); 51 EXPECT_FALSE(waiter.IsSignaled());
56 loop_.RunUntilIdle(); 52 loop_.RunUntilIdle();
57 EXPECT_TRUE(waiter.IsSignaled()); 53 EXPECT_TRUE(waiter.IsSignaled());
58 } 54 }
59 55
60 TEST_F(BindToLoopTest, Bool) { 56 TEST_F(BindToLoopTest, Bool) {
61 bool bool_var = false; 57 bool bool_var = false;
62 base::Callback<void(bool)> cb = BindToLoop(proxy_, base::Bind( 58 base::Callback<void(bool)> cb = BindToCurrentLoop(base::Bind(
63 &BoundBoolSet, &bool_var)); 59 &BoundBoolSet, &bool_var));
64 cb.Run(true); 60 cb.Run(true);
65 EXPECT_FALSE(bool_var); 61 EXPECT_FALSE(bool_var);
66 loop_.RunUntilIdle(); 62 loop_.RunUntilIdle();
67 EXPECT_TRUE(bool_var); 63 EXPECT_TRUE(bool_var);
68 } 64 }
69 65
70 TEST_F(BindToLoopTest, BoundScopedPtrBool) { 66 TEST_F(BindToLoopTest, BoundScopedPtrBool) {
71 bool bool_val = false; 67 bool bool_val = false;
72 scoped_ptr<bool> scoped_ptr_bool(new bool(true)); 68 scoped_ptr<bool> scoped_ptr_bool(new bool(true));
73 base::Closure cb = BindToLoop(proxy_, base::Bind( 69 base::Closure cb = BindToCurrentLoop(base::Bind(
74 &BoundBoolSetFromScopedPtr, &bool_val, base::Passed(&scoped_ptr_bool))); 70 &BoundBoolSetFromScopedPtr, &bool_val, base::Passed(&scoped_ptr_bool)));
75 cb.Run(); 71 cb.Run();
76 EXPECT_FALSE(bool_val); 72 EXPECT_FALSE(bool_val);
77 loop_.RunUntilIdle(); 73 loop_.RunUntilIdle();
78 EXPECT_TRUE(bool_val); 74 EXPECT_TRUE(bool_val);
79 } 75 }
80 76
81 TEST_F(BindToLoopTest, PassedScopedPtrBool) { 77 TEST_F(BindToLoopTest, PassedScopedPtrBool) {
82 bool bool_val = false; 78 bool bool_val = false;
83 scoped_ptr<bool> scoped_ptr_bool(new bool(true)); 79 scoped_ptr<bool> scoped_ptr_bool(new bool(true));
84 base::Callback<void(scoped_ptr<bool>)> cb = BindToLoop(proxy_, base::Bind( 80 base::Callback<void(scoped_ptr<bool>)> cb = BindToCurrentLoop(base::Bind(
85 &BoundBoolSetFromScopedPtr, &bool_val)); 81 &BoundBoolSetFromScopedPtr, &bool_val));
86 cb.Run(scoped_ptr_bool.Pass()); 82 cb.Run(scoped_ptr_bool.Pass());
87 EXPECT_FALSE(bool_val); 83 EXPECT_FALSE(bool_val);
88 loop_.RunUntilIdle(); 84 loop_.RunUntilIdle();
89 EXPECT_TRUE(bool_val); 85 EXPECT_TRUE(bool_val);
90 } 86 }
91 87
92 TEST_F(BindToLoopTest, BoundScopedArrayBool) { 88 TEST_F(BindToLoopTest, BoundScopedArrayBool) {
93 bool bool_val = false; 89 bool bool_val = false;
94 scoped_ptr<bool[]> scoped_array_bool(new bool[1]); 90 scoped_ptr<bool[]> scoped_array_bool(new bool[1]);
95 scoped_array_bool[0] = true; 91 scoped_array_bool[0] = true;
96 base::Closure cb = BindToLoop(proxy_, base::Bind( 92 base::Closure cb = BindToCurrentLoop(base::Bind(
97 &BoundBoolSetFromScopedArray, &bool_val, 93 &BoundBoolSetFromScopedArray, &bool_val,
98 base::Passed(&scoped_array_bool))); 94 base::Passed(&scoped_array_bool)));
99 cb.Run(); 95 cb.Run();
100 EXPECT_FALSE(bool_val); 96 EXPECT_FALSE(bool_val);
101 loop_.RunUntilIdle(); 97 loop_.RunUntilIdle();
102 EXPECT_TRUE(bool_val); 98 EXPECT_TRUE(bool_val);
103 } 99 }
104 100
105 TEST_F(BindToLoopTest, PassedScopedArrayBool) { 101 TEST_F(BindToLoopTest, PassedScopedArrayBool) {
106 bool bool_val = false; 102 bool bool_val = false;
107 scoped_ptr<bool[]> scoped_array_bool(new bool[1]); 103 scoped_ptr<bool[]> scoped_array_bool(new bool[1]);
108 scoped_array_bool[0] = true; 104 scoped_array_bool[0] = true;
109 base::Callback<void(scoped_ptr<bool[]>)> cb = BindToLoop(proxy_, base::Bind( 105 base::Callback<void(scoped_ptr<bool[]>)> cb = BindToCurrentLoop(base::Bind(
110 &BoundBoolSetFromScopedArray, &bool_val)); 106 &BoundBoolSetFromScopedArray, &bool_val));
111 cb.Run(scoped_array_bool.Pass()); 107 cb.Run(scoped_array_bool.Pass());
112 EXPECT_FALSE(bool_val); 108 EXPECT_FALSE(bool_val);
113 loop_.RunUntilIdle(); 109 loop_.RunUntilIdle();
114 EXPECT_TRUE(bool_val); 110 EXPECT_TRUE(bool_val);
115 } 111 }
116 112
117 TEST_F(BindToLoopTest, BoundScopedPtrMallocBool) { 113 TEST_F(BindToLoopTest, BoundScopedPtrMallocBool) {
118 bool bool_val = false; 114 bool bool_val = false;
119 scoped_ptr_malloc<bool> scoped_ptr_malloc_bool( 115 scoped_ptr_malloc<bool> scoped_ptr_malloc_bool(
120 static_cast<bool*>(malloc(sizeof(bool)))); 116 static_cast<bool*>(malloc(sizeof(bool))));
121 *scoped_ptr_malloc_bool = true; 117 *scoped_ptr_malloc_bool = true;
122 base::Closure cb = BindToLoop(proxy_, base::Bind( 118 base::Closure cb = BindToCurrentLoop(base::Bind(
123 &BoundBoolSetFromScopedPtrMalloc, &bool_val, 119 &BoundBoolSetFromScopedPtrMalloc, &bool_val,
124 base::Passed(&scoped_ptr_malloc_bool))); 120 base::Passed(&scoped_ptr_malloc_bool)));
125 cb.Run(); 121 cb.Run();
126 EXPECT_FALSE(bool_val); 122 EXPECT_FALSE(bool_val);
127 loop_.RunUntilIdle(); 123 loop_.RunUntilIdle();
128 EXPECT_TRUE(bool_val); 124 EXPECT_TRUE(bool_val);
129 } 125 }
130 126
131 TEST_F(BindToLoopTest, PassedScopedPtrMallocBool) { 127 TEST_F(BindToLoopTest, PassedScopedPtrMallocBool) {
132 bool bool_val = false; 128 bool bool_val = false;
133 scoped_ptr_malloc<bool> scoped_ptr_malloc_bool( 129 scoped_ptr_malloc<bool> scoped_ptr_malloc_bool(
134 static_cast<bool*>(malloc(sizeof(bool)))); 130 static_cast<bool*>(malloc(sizeof(bool))));
135 *scoped_ptr_malloc_bool = true; 131 *scoped_ptr_malloc_bool = true;
136 base::Callback<void(scoped_ptr_malloc<bool>)> cb = BindToLoop( 132 base::Callback<void(scoped_ptr_malloc<bool>)> cb = BindToCurrentLoop(
137 proxy_, base::Bind(&BoundBoolSetFromScopedPtrMalloc, &bool_val)); 133 base::Bind(&BoundBoolSetFromScopedPtrMalloc, &bool_val));
138 cb.Run(scoped_ptr_malloc_bool.Pass()); 134 cb.Run(scoped_ptr_malloc_bool.Pass());
139 EXPECT_FALSE(bool_val); 135 EXPECT_FALSE(bool_val);
140 loop_.RunUntilIdle(); 136 loop_.RunUntilIdle();
141 EXPECT_TRUE(bool_val); 137 EXPECT_TRUE(bool_val);
142 } 138 }
143 139
144 TEST_F(BindToLoopTest, BoolConstRef) { 140 TEST_F(BindToLoopTest, BoolConstRef) {
145 bool bool_var = false; 141 bool bool_var = false;
146 bool true_var = true; 142 bool true_var = true;
147 const bool& true_ref = true_var; 143 const bool& true_ref = true_var;
148 base::Closure cb = BindToLoop(proxy_, base::Bind( 144 base::Closure cb = BindToCurrentLoop(base::Bind(
149 &BoundBoolSetFromConstRef, &bool_var, true_ref)); 145 &BoundBoolSetFromConstRef, &bool_var, true_ref));
150 cb.Run(); 146 cb.Run();
151 EXPECT_FALSE(bool_var); 147 EXPECT_FALSE(bool_var);
152 loop_.RunUntilIdle(); 148 loop_.RunUntilIdle();
153 EXPECT_TRUE(bool_var); 149 EXPECT_TRUE(bool_var);
154 } 150 }
155 151
156 TEST_F(BindToLoopTest, Integers) { 152 TEST_F(BindToLoopTest, Integers) {
157 int a = 0; 153 int a = 0;
158 int b = 0; 154 int b = 0;
159 base::Callback<void(int, int)> cb = BindToLoop(proxy_, base::Bind( 155 base::Callback<void(int, int)> cb = BindToCurrentLoop(base::Bind(
160 &BoundIntegersSet, &a, &b)); 156 &BoundIntegersSet, &a, &b));
161 cb.Run(1, -1); 157 cb.Run(1, -1);
162 EXPECT_EQ(a, 0); 158 EXPECT_EQ(a, 0);
163 EXPECT_EQ(b, 0); 159 EXPECT_EQ(b, 0);
164 loop_.RunUntilIdle(); 160 loop_.RunUntilIdle();
165 EXPECT_EQ(a, 1); 161 EXPECT_EQ(a, 1);
166 EXPECT_EQ(b, -1); 162 EXPECT_EQ(b, -1);
167 } 163 }
168 164
169 } // namespace media 165 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698