Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 6695032: Convert dom_storage, pepper, pepper_file, and automation messages to new form... (Closed)

Created:
9 years, 9 months ago by Tom Sepez
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Convert dom_storage, pepper, pepper_file, and automation messages to new format. dom_storage now generated by the common generator. Pepper and pepper_file still have dedicated .cc files rather than using the common generator because they still contain a small amount of hand-coded code. Automation_messages has its own .cc file, since it appears this may well link into other places. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78330

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -188 lines) Patch
M chrome/chrome_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/automation_messages.h View 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/common/common_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/dom_storage_messages.h View 3 chunks +11 lines, -43 lines 0 comments Download
D chrome/common/dom_storage_messages.cc View 1 chunk +0 lines, -125 lines 0 comments Download
M chrome/common/pepper_file_messages.h View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/common/pepper_messages.h View 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Tom Sepez
Last conversion from old CL.
9 years, 9 months ago (2011-03-15 20:54:45 UTC) #1
jam
I think we should try to avoid copying that block of code unless absolutely necessary. ...
9 years, 9 months ago (2011-03-15 21:57:28 UTC) #2
Tom Sepez
Makes sense. Would be OK to do as a follow-up task?
9 years, 9 months ago (2011-03-15 22:02:15 UTC) #3
jam
On 2011/03/15 22:02:15, Tom Sepez wrote: > Makes sense. Would be OK to do as ...
9 years, 9 months ago (2011-03-15 22:03:45 UTC) #4
Tom Sepez
Need the .h files to be converted, at the least, to generate the ipclist tables.
9 years, 9 months ago (2011-03-15 22:12:05 UTC) #5
jam
ok, can we do just the header file change in the meantime? On Tue, Mar ...
9 years, 9 months ago (2011-03-15 22:26:00 UTC) #6
Tom Sepez
Sure thing. Like this?
9 years, 9 months ago (2011-03-15 22:36:18 UTC) #7
jam
9 years, 9 months ago (2011-03-15 22:37:01 UTC) #8
On 2011/03/15 22:36:18, Tom Sepez wrote:
> Sure thing.  Like this?

yep, lgtm

Powered by Google App Engine
This is Rietveld 408576698