Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Side by Side Diff: Source/core/dom/ScriptRunner.h

Issue 669503003: Revert of Refactor Script(Loader|Runner): don't access Resources all over the place... (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/ScriptLoader.cpp ('k') | Source/core/dom/ScriptRunner.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 20 matching lines...) Expand all
31 #include "platform/heap/Handle.h" 31 #include "platform/heap/Handle.h"
32 #include "wtf/HashMap.h" 32 #include "wtf/HashMap.h"
33 #include "wtf/Noncopyable.h" 33 #include "wtf/Noncopyable.h"
34 #include "wtf/PassOwnPtr.h" 34 #include "wtf/PassOwnPtr.h"
35 #include "wtf/Vector.h" 35 #include "wtf/Vector.h"
36 36
37 namespace blink { 37 namespace blink {
38 38
39 class ScriptResource; 39 class ScriptResource;
40 class Document; 40 class Document;
41 class PendingScript;
41 class ScriptLoader; 42 class ScriptLoader;
42 43
43 class ScriptRunner final : public NoBaseWillBeGarbageCollectedFinalized<ScriptRu nner> { 44 class ScriptRunner final : public NoBaseWillBeGarbageCollectedFinalized<ScriptRu nner> {
44 WTF_MAKE_NONCOPYABLE(ScriptRunner); WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED; 45 WTF_MAKE_NONCOPYABLE(ScriptRunner); WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
45 public: 46 public:
46 static PassOwnPtrWillBeRawPtr<ScriptRunner> create(Document* document) 47 static PassOwnPtrWillBeRawPtr<ScriptRunner> create(Document* document)
47 { 48 {
48 return adoptPtrWillBeNoop(new ScriptRunner(document)); 49 return adoptPtrWillBeNoop(new ScriptRunner(document));
49 } 50 }
50 ~ScriptRunner(); 51 ~ScriptRunner();
51 52
52 enum ExecutionType { ASYNC_EXECUTION, IN_ORDER_EXECUTION }; 53 enum ExecutionType { ASYNC_EXECUTION, IN_ORDER_EXECUTION };
53 void queueScriptForExecution(ScriptLoader*, ExecutionType); 54 void queueScriptForExecution(ScriptLoader*, ResourcePtr<ScriptResource>, Exe cutionType);
54 bool hasPendingScripts() const { return !m_scriptsToExecuteSoon.isEmpty() || !m_scriptsToExecuteInOrder.isEmpty() || !m_pendingAsyncScripts.isEmpty(); } 55 bool hasPendingScripts() const { return !m_scriptsToExecuteSoon.isEmpty() || !m_scriptsToExecuteInOrder.isEmpty() || !m_pendingAsyncScripts.isEmpty(); }
55 void suspend(); 56 void suspend();
56 void resume(); 57 void resume();
57 void notifyScriptReady(ScriptLoader*, ExecutionType); 58 void notifyScriptReady(ScriptLoader*, ExecutionType);
58 void notifyScriptLoadError(ScriptLoader*, ExecutionType); 59 void notifyScriptLoadError(ScriptLoader*, ExecutionType);
59 60
60 void movePendingAsyncScript(ScriptRunner*, ScriptLoader*); 61 void movePendingAsyncScript(ScriptRunner*, ScriptLoader*);
61 62
62 void trace(Visitor*); 63 void trace(Visitor*);
63 64
64 private: 65 private:
65 explicit ScriptRunner(Document*); 66 explicit ScriptRunner(Document*);
66 67
67 void timerFired(Timer<ScriptRunner>*); 68 void timerFired(Timer<ScriptRunner>*);
68 69
69 void addPendingAsyncScript(ScriptLoader*); 70 void addPendingAsyncScript(ScriptLoader*, const PendingScript&);
70 71
71 RawPtrWillBeMember<Document> m_document; 72 RawPtrWillBeMember<Document> m_document;
72 Vector<ScriptLoader*> m_scriptsToExecuteInOrder; 73 // FIXME: Oilpan: consider using heap vectors and hash map here;
73 Vector<ScriptLoader*> m_scriptsToExecuteSoon; // http://www.whatwg.org/specs /web-apps/current-work/#set-of-scripts-that-will-execute-as-soon-as-possible 74 // PendingScript does have a (trivial) destructor, however.
74 HashSet<ScriptLoader*> m_pendingAsyncScripts; 75 Vector<PendingScript> m_scriptsToExecuteInOrder;
76 Vector<PendingScript> m_scriptsToExecuteSoon; // http://www.whatwg.org/specs /web-apps/current-work/#set-of-scripts-that-will-execute-as-soon-as-possible
77 WillBeHeapHashMap<ScriptLoader*, PendingScript> m_pendingAsyncScripts;
75 Timer<ScriptRunner> m_timer; 78 Timer<ScriptRunner> m_timer;
76 }; 79 };
77 80
78 } 81 }
79 82
80 #endif 83 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/ScriptLoader.cpp ('k') | Source/core/dom/ScriptRunner.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698