Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 669443002: Fix ChildProcessLauncher::SetProcessBackgrounded(...) function. (Closed)

Created:
6 years, 2 months ago by Kibeom Kim (inactive)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix ChildProcessLauncher::SetProcessBackgrounded(...) function. Recently class was refactored https://codereview.chromium.org/651253002 , and there was an unexpected functional change. BUG=424816 Committed: https://crrev.com/a13b509667a821c9f0d0b0b54f6854993cac761e Cr-Commit-Position: refs/heads/master@{#300310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/child_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Kibeom Kim (inactive)
6 years, 2 months ago (2014-10-18 08:10:59 UTC) #2
rvargas (doing something else)
LGTM, sorry about that.
6 years, 2 months ago (2014-10-20 17:54:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669443002/1
6 years, 2 months ago (2014-10-20 17:54:30 UTC) #5
Kibeom Kim (inactive)
sievers@ : ptal (OWNER)
6 years, 2 months ago (2014-10-20 17:56:38 UTC) #8
no sievers
lgtm
6 years, 2 months ago (2014-10-20 18:09:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669443002/1
6 years, 2 months ago (2014-10-20 18:13:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 19:19:31 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 19:20:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a13b509667a821c9f0d0b0b54f6854993cac761e
Cr-Commit-Position: refs/heads/master@{#300310}

Powered by Google App Engine
This is Rietveld 408576698