Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 669433002: cc: Invalidate eviction tiles cache when a tile is deleted. (Closed)

Created:
6 years, 2 months ago by vmpstr
Modified:
6 years, 2 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Invalidate eviction tiles cache when a tile is deleted. This patch ensures that the eviction tiles cache becomes invalid when a tile is removed from it. Without this patch, it is possible that the eviction cache holds on to a tile pointer that would end up pointing to a deleted tile (and thus when it gets evicted, we'll access an invalid tile). BUG=424487 R=reveman Committed: https://crrev.com/706afa6fe732449d962c9b17a723afa86a8c7bf4 Cr-Commit-Position: refs/heads/master@{#300222}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M cc/resources/picture_layer_tiling.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
vmpstr
PTAL
6 years, 2 months ago (2014-10-18 08:10:14 UTC) #1
reveman
lgtm https://codereview.chromium.org/669433002/diff/1/cc/resources/picture_layer_tiling_unittest.cc File cc/resources/picture_layer_tiling_unittest.cc (right): https://codereview.chromium.org/669433002/diff/1/cc/resources/picture_layer_tiling_unittest.cc#newcode67 cc/resources/picture_layer_tiling_unittest.cc:67: bool get_eviction_tiles_cache_valid() const { nit: simply "eviction_tiles_cache_valid"
6 years, 2 months ago (2014-10-18 17:09:15 UTC) #2
vmpstr
https://codereview.chromium.org/669433002/diff/1/cc/resources/picture_layer_tiling_unittest.cc File cc/resources/picture_layer_tiling_unittest.cc (right): https://codereview.chromium.org/669433002/diff/1/cc/resources/picture_layer_tiling_unittest.cc#newcode67 cc/resources/picture_layer_tiling_unittest.cc:67: bool get_eviction_tiles_cache_valid() const { On 2014/10/18 17:09:15, reveman wrote: ...
6 years, 2 months ago (2014-10-18 19:31:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669433002/20001
6 years, 2 months ago (2014-10-18 19:43:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-18 22:05:11 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 22:05:54 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/706afa6fe732449d962c9b17a723afa86a8c7bf4
Cr-Commit-Position: refs/heads/master@{#300222}

Powered by Google App Engine
This is Rietveld 408576698