Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 669423002: Only dispose proxy-less WebServiceWorkerRegistration objects. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 1 month ago
Reviewers:
falken, haraken, nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Only dispose proxy-less WebServiceWorkerRegistration objects. If a service worker registration is passed along to a resolver that's in a detached/stopping state, the WebServiceWorkerRegistration is simply disposed of. Have that dispose step only delete the object if the registration object isn't attached to a proxy already. If it is, it is responsible for releasing the resource. R=haraken BUG=426321 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. No test provided - don't know how to write such a ...
6 years, 2 months ago (2014-10-23 13:48:02 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-10-23 15:33:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669423002/1
6 years, 1 month ago (2014-10-23 17:14:57 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-23 17:18:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184288

Powered by Google App Engine
This is Rietveld 408576698