Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 669413002: Telemetry: Update the user agent version. (Closed)

Created:
6 years, 2 months ago by marja
Modified:
6 years, 2 months ago
Reviewers:
dtu, ernstm, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Update the user agent version. The version was so old that recording some modern web pages failed. BUG=425548 Committed: https://crrev.com/bae68443fb41cf6796942f6e037a6ad6afd1b687 Cr-Commit-Position: refs/heads/master@{#301098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tools/telemetry/telemetry/core/user_agent.py View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
Telemetry people; is updating the user agent this simple, or will something likely break? Idk ...
6 years, 2 months ago (2014-10-23 12:05:49 UTC) #2
tonyg
lgtm I'm pretty sure this'll just work (although there might be a unittest to update). ...
6 years, 2 months ago (2014-10-23 16:43:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669413002/1
6 years, 2 months ago (2014-10-24 13:31:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 14:31:54 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 14:32:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bae68443fb41cf6796942f6e037a6ad6afd1b687
Cr-Commit-Position: refs/heads/master@{#301098}

Powered by Google App Engine
This is Rietveld 408576698