Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 669403002: Fixed mutable heap numbers leak in JSON parser. (Closed)

Created:
6 years, 2 months ago by Igor Sheludko
Modified:
6 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fixed mutable heap numbers leak in JSON parser. BUG=chromium:423687 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24849

Patch Set 1 #

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -19 lines) Patch
M src/json-parser.h View 1 3 chunks +42 lines, -14 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-423687.js View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Igor Sheludko
PTAL
6 years, 2 months ago (2014-10-23 10:11:14 UTC) #2
Toon Verwaest
lgtm
6 years, 2 months ago (2014-10-23 10:25:22 UTC) #3
Igor Sheludko
6 years, 2 months ago (2014-10-23 14:41:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 24849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698