Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 669373002: pass isolate to Value::To* functions (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

pass isolate to Value::To* functions BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24893

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase for try bots #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -32 lines) Patch
M include/v8.h View 2 chunks +56 lines, -8 lines 0 comments Download
M src/api.cc View 1 2 10 chunks +18 lines, -18 lines 0 comments Download
M src/d8.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M src/d8-debug.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/statistics-extension.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Sven Panne
lgtm
6 years, 2 months ago (2014-10-23 12:11:07 UTC) #2
dcarney
6 years, 1 month ago (2014-10-27 09:02:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 24893 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698