Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: LayoutTests/fast/canvas/resources/canvas-createImageBitmap-invalid-args-in-workers.js

Issue 669353002: Fix broken Promise-related layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@return-rejected
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/canvas/resources/canvas-createImageBitmap-invalid-args-in-workers.js
diff --git a/LayoutTests/fast/canvas/resources/canvas-createImageBitmap-invalid-args-in-workers.js b/LayoutTests/fast/canvas/resources/canvas-createImageBitmap-invalid-args-in-workers.js
index e76a40fb58522df4fd9dca07e9eaa9e1580e45e5..633f4e9d4a735cd453aaf56302a6ba4f5ff79ce2 100644
--- a/LayoutTests/fast/canvas/resources/canvas-createImageBitmap-invalid-args-in-workers.js
+++ b/LayoutTests/fast/canvas/resources/canvas-createImageBitmap-invalid-args-in-workers.js
@@ -4,12 +4,30 @@ self.jsTestIsAsync = true;
description('Test createImageBitmap with invalid arguments in workers.');
+var reason;
+
+function shouldBeRejected(promise, message) {
+ return promise.then(function() {
+ testFailed('Resolved unexpectedly: ' + message);
+ }, function(e) {
+ reason = e;
+ testPassed('Rejected as expected: ' + message);
+ shouldBeTrue('reason instanceof Error');
+ debug(String(e));
+ });
+}
+
var data;
self.addEventListener('message', function(e) {
- data = e.data;
- shouldThrow("createImageBitmap(null, 0, 0, 10, 10)");
- shouldThrow("createImageBitmap(data, 0, 0, 10, 0)");
- shouldThrow("createImageBitmap(data, 0, 0, 0, 10)");
- finishJSTest();
+ data = e.data;
+ Promise.resolve().then(function() {
+ return shouldBeRejected(createImageBitmap(null, 0, 0, 10, 10), 'null');
+ }).then(function() {
+ return shouldBeRejected(createImageBitmap(data, 0, 0, 10, 0), 'invalid area');
+ }).then(function() {
+ return shouldBeRejected(createImageBitmap(data, 0, 0, 0, 10), 'invalid area');
+ }).catch(function(e) {
+ testFailed('Unexpected rejection: ' + e);
+ }).then(finishJSTest, finishJSTest);
});

Powered by Google App Engine
This is Rietveld 408576698