Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669353002: Fix broken Promise-related layout tests. (Closed)

Created:
6 years, 2 months ago by yhirano
Modified:
6 years, 2 months ago
Reviewers:
Justin Novosad, nhiroki
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@return-rejected
Project:
blink
Visibility:
Public.

Description

Fix broken Promise-related layout tests. Because of the bindings change related to Promise-returning functions (see http://crbug.com/359411), some layout tests that had been written before that have been broken. As the bindings change is done, this CL fixes these tests. BUG=362992 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184319

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -197 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args.html View 1 chunk +110 lines, -130 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt View 1 chunk +60 lines, -20 lines 2 comments Download
M LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-in-workers-expected.txt View 1 chunk +9 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/resources/canvas-createImageBitmap-invalid-args-in-workers.js View 1 chunk +23 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/security/cross-origin-createImageBitmap.html View 1 chunk +38 lines, -20 lines 0 comments Download
M LayoutTests/http/tests/security/cross-origin-createImageBitmap-expected.txt View 1 chunk +6 lines, -2 lines 0 comments Download
M LayoutTests/storage/quota/storagequota-query-info.html View 1 chunk +10 lines, -4 lines 0 comments Download
M LayoutTests/storage/quota/storagequota-query-info-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/storage/quota/storagequota-request-persistent-quota.html View 1 chunk +5 lines, -2 lines 0 comments Download
M LayoutTests/storage/quota/storagequota-request-persistent-quota-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yhirano
This CL depends on https://codereview.chromium.org/675693002/ (so tries will fail).
6 years, 2 months ago (2014-10-23 08:02:09 UTC) #2
yhirano
https://codereview.chromium.org/669353002/diff/1/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt File LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt (right): https://codereview.chromium.org/669353002/diff/1/LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt#newcode61 LayoutTests/fast/canvas/canvas-createImageBitmap-invalid-args-expected.txt:61: FAIL reason instanceof Error should be true. Was false. ...
6 years, 2 months ago (2014-10-23 08:03:59 UTC) #3
nhiroki
LGTM for storage/quota
6 years, 2 months ago (2014-10-23 10:27:05 UTC) #4
Justin Novosad
On 2014/10/23 10:27:05, nhiroki wrote: > LGTM for storage/quota lgtm for the layout tests
6 years, 2 months ago (2014-10-23 14:54:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669353002/1
6 years, 2 months ago (2014-10-23 23:37:31 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 00:39:20 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184319

Powered by Google App Engine
This is Rietveld 408576698