Issue 669333002: Disable ServiceWorkerBlackBoxBrowserTest.Registration on ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669333002: Disable ServiceWorkerBlackBoxBrowserTest.Registration on ChromeOS (Closed)

Created:
6 years, 2 months ago by Kunihiko Sakamoto

Modified:
6 years, 2 months ago

Reviewers:
falken, horo

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable ServiceWorkerBlackBoxBrowserTest.Registration on ChromeOS This partially reverts r300403. The test was still flaking on ChromeOS. BUG=387045 Committed: https://crrev.com/6445dc250cc32cb7e0e8ce6ca7ab1058776effec Cr-Commit-Position: refs/heads/master@{#301034}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	content/browser/service_worker/service_worker_browsertest.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

falken

On 2014/10/23 07:23:15, Kunihiko Sakamoto wrote: sorry for slow review. lgtm

6 years, 2 months ago (2014-10-24 01:47:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669333002/1

6 years, 2 months ago (2014-10-24 01:50:17 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-24 03:49:12 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6445dc250cc32cb7e0e8ce6ca7ab1058776effec
Cr-Commit-Position: refs/heads/master@{#301034}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages