Issue 669323002: Oilpan: Clarify ownership of split-off heaps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669323002: Oilpan: Clarify ownership of split-off heaps. (Closed)

Created:
6 years, 2 months ago by tkent

Modified:
6 years, 2 months ago

Reviewers:
oilpan-reviews, haraken, sof

CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium), mkwst+moarreviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Clarify ownership of split-off heaps. - BaseHeap::split() should return PassOwnPtr<BaseHeap>. - BaseHeap::merge() should take a PassOwnPtr<BaseHeap> argument. BUG=420515 TEST=None; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184255

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	Source/platform/heap/Heap.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/platform/heap/Heap.cpp	View	4 chunks	+5 lines, -6 lines	0 comments	Download
M	Source/platform/heap/ThreadState.cpp	View	3 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669323002/1

6 years, 2 months ago (2014-10-23 05:11:43 UTC) #7

commit-bot: I haz the power

6 years, 2 months ago (2014-10-23 11:03:41 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184255

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages