Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 669243002: MacViews: Get c/b/ui/views/tabs to build on Mac (Closed)

Created:
6 years, 2 months ago by Andre
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dcheng, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MacViews: Get c/b/ui/views/tabs to build on Mac Isolate aura and ash dependencies since they are not included on Mac. Change GetLocalProcessWindowAtPoint to work with gfx::NativeWindow. Add window_finder_mac.mm BUG=425229 Committed: https://crrev.com/48602c37b1f027823b7908080c8e026d5607807f Cr-Commit-Position: refs/heads/master@{#301235}

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -49 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 1 13 chunks +32 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_ash.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_chromeos.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A chrome/browser/ui/views/tabs/window_finder_mac.mm View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_x11.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Andre
sky@ PTAL.
6 years, 2 months ago (2014-10-24 20:22:02 UTC) #4
sky
LGTM
6 years, 2 months ago (2014-10-24 22:20:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669243002/60001
6 years, 2 months ago (2014-10-24 22:32:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 2 months ago (2014-10-24 23:54:21 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 23:55:25 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48602c37b1f027823b7908080c8e026d5607807f
Cr-Commit-Position: refs/heads/master@{#301235}

Powered by Google App Engine
This is Rietveld 408576698