Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 66923002: remove bogus assert, and remove outdated #ifdef (Closed)

Created:
7 years, 1 month ago by reed1
Modified:
7 years, 1 month ago
Reviewers:
epoger, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove bogus assert, and remove outdated #ifdef BUG=https://code.google.com/p/skia/issues/detail?id=1820 R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=12196

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M src/core/SkBlitter_A8.cpp View 4 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
All of the code being removed was leftover from an experiment, where we did not ...
7 years, 1 month ago (2013-11-08 16:13:51 UTC) #1
reed1
7 years, 1 month ago (2013-11-08 16:14:01 UTC) #2
robertphillips
lgtm
7 years, 1 month ago (2013-11-08 16:44:00 UTC) #3
reed1
Committed patchset #1 manually as r12196 (presubmit successful).
7 years, 1 month ago (2013-11-08 17:50:21 UTC) #4
epoger
7 years, 1 month ago (2013-11-08 17:54:27 UTC) #5
Message was sent while issue was closed.
I take it this is a fix for https://code.google.com/p/skia/issues/detail?id=1820
('SkBlitter_A8 assertion failure on Test-Android-Xoom-Tegra2-Arm7-Debug
builder') ?

Powered by Google App Engine
This is Rietveld 408576698