Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 669213004: remove IsInHighDPIMode (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, oshima, ananta
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove IsInHighDPIMode Some simplifications before using this code on Linux. R=sky@chromium.org BUG=143619 Committed: https://crrev.com/13b1371303258fe761e907d5874cdfdf8e3ed082 Cr-Commit-Position: refs/heads/master@{#300840}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M ui/gfx/screen_win.cc View 2 chunks +2 lines, -2 lines 1 comment Download
M ui/gfx/win/dpi.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/win/dpi.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
First of a bunch of the cleanups suggested by https://codereview.chromium.org/659883002/. https://codereview.chromium.org/669213004/diff/1/ui/gfx/screen_win.cc File ui/gfx/screen_win.cc (right): https://codereview.chromium.org/669213004/diff/1/ui/gfx/screen_win.cc#newcode96 ...
6 years, 1 month ago (2014-10-23 02:42:07 UTC) #1
sky
LGTM
6 years, 1 month ago (2014-10-23 04:15:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669213004/1
6 years, 1 month ago (2014-10-23 04:18:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-23 05:07:46 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-23 05:08:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13b1371303258fe761e907d5874cdfdf8e3ed082
Cr-Commit-Position: refs/heads/master@{#300840}

Powered by Google App Engine
This is Rietveld 408576698