Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3664)

Unified Diff: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h

Issue 669163003: Handle disabling data reduction proxy for all platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed bengr's changes Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h
diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h
index 72051708f584d22c2c25363b4efefa6685496208..8e1fe22b14620ee3770e588c21b2af5833f43811 100644
--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h
+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_configurator.h
@@ -32,6 +32,10 @@ class DataReductionProxyChromeConfigurator
scoped_refptr<base::SequencedTaskRunner> network_task_runner);
~DataReductionProxyChromeConfigurator() override;
+ // Set the proxy entry in browser preference to use the default system prefs
bengr 2014/10/29 23:41:25 I wouldn't be so specific. How about: // Removes
Not at Google. Contact bengr 2014/10/30 00:05:03 Done.
+ // and clears the server and bypass list.
+ static void DisableInProxyConfigPref(PrefService* prefs);
+
void Enable(bool primary_restricted,
bool fallback_restricted,
const std::string& primary_origin,
@@ -61,6 +65,10 @@ class DataReductionProxyChromeConfigurator
private:
FRIEND_TEST_ALL_PREFIXES(DataReductionProxyConfigTest, TestBypassList);
+ // Check whether the |proxy_rules| contain any of the data reduction proxies.
bengr 2014/10/29 23:41:25 Coordinate with megjablon@ who is also querying Pr
Not at Google. Contact bengr 2014/10/30 00:05:03 Done.
+ static bool ContainsDataReductionProxy(
+ const net::ProxyConfig::ProxyRules& proxy_rules);
+
PrefService* prefs_;
scoped_refptr<base::SequencedTaskRunner> network_task_runner_;

Powered by Google App Engine
This is Rietveld 408576698