Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 669153009: Sync Telemetry to trace-viewer changes. (Closed)

Created:
6 years, 2 months ago by dsinclair
Modified:
6 years, 2 months ago
Reviewers:
nednguyen, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org, xunjieli, nednguyen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Sync Telemetry to trace-viewer changes. The tvcm HTML files were shuffled around in the trace-viewer repo and moved back up to a higher directory. The tvcm prefix was renamed to tv to show they are no longer in tvcm itself. This CL updates the telemetry files to match the new trace-viewer structure. This includes the DEPs roll in order to get the new structure from trace-viewer. Committed: https://crrev.com/c1a7469dec3953f9d2539fc6b6db9e32deedb217 Cr-Commit-Position: refs/heads/master@{#301123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_components/results_viewer.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_components/results_viewer_unittest.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/web_components/tvcm_stub.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_components/viewer_unittest_data.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/web_components/web_component_bootstrap.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL. This fixes up telemetry to unblock the trace-viewer deps roll (which is included in ...
6 years, 2 months ago (2014-10-24 14:12:28 UTC) #2
nednguyen
Since this is mere naming change, I can give you the owner stamp? LGTM
6 years, 2 months ago (2014-10-24 14:49:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669153009/1
6 years, 2 months ago (2014-10-24 14:51:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 16:36:52 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:37:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1a7469dec3953f9d2539fc6b6db9e32deedb217
Cr-Commit-Position: refs/heads/master@{#301123}

Powered by Google App Engine
This is Rietveld 408576698