util/file/fd_io.cc - Issue 669153006: Add HTTPBodyStream interface, three concrete implementations, and their tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/file/fd_io.cc

Issue 669153006: Add HTTPBodyStream interface, three concrete implementations, and their tests. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Close and read error logging Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: util/file/fd_io.cc

diff --git a/util/file/fd_io.cc b/util/file/fd_io.cc

index 46a3634fc7cda80e08ca6a83ec104170d6936b15..df4b3e93f227aac47a9a8f67c56cb00ffeace989 100644

--- a/util/file/fd_io.cc

+++ b/util/file/fd_io.cc

@@ -104,4 +104,10 @@ void CheckedReadFDAtEOF(int fd) {

}

+int CloseFD(int fd) {

+ int rv = IGNORE_EINTR(close(fd));

+ PLOG_IF(ERROR, rv != 0) << "close";

+ return rv;

} // namespace crashpad

« util/file/fd_io.h ('K') | « util/file/fd_io.h ('k') | util/net/http_body.h » ('j') | util/net/http_body.cc » ('J')