Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: util/file/fd_io.cc

Issue 669153006: Add HTTPBodyStream interface, three concrete implementations, and their tests. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/file/fd_io.h ('k') | util/net/http_body.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 void CheckedReadFDAtEOF(int fd) { 97 void CheckedReadFDAtEOF(int fd) {
98 char c; 98 char c;
99 ssize_t rv = ReadFD(fd, &c, 1); 99 ssize_t rv = ReadFD(fd, &c, 1);
100 if (rv < 0) { 100 if (rv < 0) {
101 PCHECK(rv == 0) << "read"; 101 PCHECK(rv == 0) << "read";
102 } else { 102 } else {
103 CHECK_EQ(rv, 0) << "read"; 103 CHECK_EQ(rv, 0) << "read";
104 } 104 }
105 } 105 }
106 106
107 bool LoggingCloseFD(int fd) {
108 int rv = IGNORE_EINTR(close(fd));
109 PLOG_IF(ERROR, rv != 0) << "close";
110 return rv == 0;
111 }
112
107 } // namespace crashpad 113 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/file/fd_io.h ('k') | util/net/http_body.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698