Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669153004: Include all headers in bindings_core_v8_files. (Closed)

Created:
6 years, 2 months ago by vogelheim
Modified:
6 years, 2 months ago
Reviewers:
haraken, marja
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Include all headers in bindings_core_v8_files. BUG= R=marja@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/bindings/core/v8/v8.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vogelheim
I checked for other missing headers while I was at it, and it turns out ...
6 years, 2 months ago (2014-10-22 16:48:41 UTC) #1
marja
lgtm
6 years, 2 months ago (2014-10-22 17:45:30 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-22 23:33:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669153004/1
6 years, 2 months ago (2014-10-23 10:31:37 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 10:35:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184254

Powered by Google App Engine
This is Rietveld 408576698