src/compiler/simplified-lowering.cc - Issue 669133004: [turbofan] Improve code generation for inline comparisons with zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/simplified-lowering.cc

Issue 669133004: [turbofan] Improve code generation for inline comparisons with zero. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: REBASE Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/simplified-lowering.cc

diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc

index 26b6bd35df8ed83fcf986408de3a8cf0057de532..20c8a567dba11c77fbe0fc824ce8ad204c12e729 100644

--- a/src/compiler/simplified-lowering.cc

+++ b/src/compiler/simplified-lowering.cc

@@ -456,8 +456,8 @@ class RepresentationSelector {

if (lower()) {

MachineTypeUnion input = GetInfo(node->InputAt(0))->output;

if (input & kRepBit) {

- // BooleanNot(x: kRepBit) => WordEqual(x, #0)

- node->set_op(lowering->machine()->WordEqual());

+ // BooleanNot(x: kRepBit) => Word32Equal(x, #0)

+ node->set_op(lowering->machine()->Word32Equal());

node->AppendInput(jsgraph_->zone(), jsgraph_->Int32Constant(0));

} else {

// BooleanNot(x: kRepTagged) => WordEqual(x, #false)

« no previous file with comments | « src/compiler/machine-operator-reducer.cc ('k') | src/compiler/typer.cc » ('j') | no next file with comments »