Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 669133004: [turbofan] Improve code generation for inline comparisons with zero. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve code generation for inline comparisons with zero. TEST=cctest,unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24832

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Final version. #

Patch Set 4 : Unit tests. #

Patch Set 5 : Improved test. #

Patch Set 6 : Even better now! #

Patch Set 7 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+481 lines, -220 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 5 chunks +79 lines, -113 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 6 chunks +83 lines, -84 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 2 chunks +13 lines, -13 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 5 chunks +43 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +136 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 2 3 4 5 1 chunk +107 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-23 09:00:06 UTC) #2
dcarney
lgtm
6 years, 2 months ago (2014-10-23 09:38:47 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-23 10:22:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as 24832 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698