De-virtualize snapshot sink.

De-virtualize snapshot sink.

R=vogelheim@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24836

[vogelheim, 2014-10-22 15:02:53]

lgtm

https://codereview.chromium.org/669133003/diff/1/src/snapshot-source-sink.h
File src/snapshot-source-sink.h (right):

https://codereview.chromium.org/669133003/diff/1/src/snapshot-source-sink.h#n...
src/snapshot-source-sink.h:74: explicit SnapshotByteSink(int initial_size) :
data_(initial_size) {}
super nitpick: The destructor is non-trivial, since the class has a non-POD
member it needs to destroy. The style guide allows to let the compiler generate
it or to write it out, but it seems we mostly do the latter:
https://code.google.com/p/chromium/codesearch#search/&q=%5E%5C%20*~.*%7B%5C%2...

Anyways... no big deal either way, and entirely your choice.

https://codereview.chromium.org/669133003/diff/1/src/snapshot-source-sink.h#n...
src/snapshot-source-sink.h:76: void Put(byte b, const char* description) {
data_.Add(b); }
[here and below:]

The "description" params were potentially used by debugging code, but I guess
this change removes that option. Maybe we can remove them entirely?

[Yang, 2014-10-23 09:35:50]

https://codereview.chromium.org/669133003/diff/1/src/snapshot-source-sink.h
File src/snapshot-source-sink.h (right):

https://codereview.chromium.org/669133003/diff/1/src/snapshot-source-sink.h#n...
src/snapshot-source-sink.h:74: explicit SnapshotByteSink(int initial_size) :
data_(initial_size) {}
On 2014/10/22 15:02:53, vogelheim wrote:
> super nitpick: The destructor is non-trivial, since the class has a non-POD
> member it needs to destroy. The style guide allows to let the compiler
generate
> it or to write it out, but it seems we mostly do the latter:
>
https://code.google.com/p/chromium/codesearch#search/&q=%5E%5C%20*~.*%7B%5C%2...
> 
> Anyways... no big deal either way, and entirely your choice.

Done.

https://codereview.chromium.org/669133003/diff/1/src/snapshot-source-sink.h#n...
src/snapshot-source-sink.h:76: void Put(byte b, const char* description) {
data_.Add(b); }
On 2014/10/22 15:02:53, vogelheim wrote:
> [here and below:]
> 
> The "description" params were potentially used by debugging code, but I guess
> this change removes that option. Maybe we can remove them entirely?

I left them there so that when we really need this when debugging, it's a quick
one liner to print the description to stdout. I removed it as an experiment. The
speed up is insignificant.

[Yang, 2014-10-23 11:24:09]

Committed patchset #2 (id:20001) manually as 24836 (presubmit successful).