Fixed Shadow blur for transparent objects

Source/platform/graphics/GraphicsContext.h

 /*
  * Copyright (C) 2003, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008-2009 Torch Mobile, Inc.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 118 matching lines @@
     SkColor effectiveFillColor() const { return immutableState()->effectiveFillColor(); }
 
     void setFillPattern(PassRefPtr<Pattern>);
     Pattern* fillPattern() const { return immutableState()->fillPattern(); }
 
     void setFillGradient(PassRefPtr<Gradient>);
     Gradient* fillGradient() const { return immutableState()->fillGradient(); }
 
     SkDrawLooper* drawLooper() const { return immutableState()->drawLooper(); }
 
+    SkImageFilter* imageFilter() const { return immutableState()->imageFilter(); }
+
     bool getTransformedClipBounds(FloatRect* bounds) const;
     SkMatrix getTotalMatrix() const;
 
     void setShouldAntialias(bool antialias) { mutableState()->setShouldAntialias(antialias); }
     bool shouldAntialias() const { return immutableState()->shouldAntialias(); }
 
     // Disable the anti-aliasing optimization for scales/multiple-of-90-degrees
     // rotations of thin ("hairline") images.
     // Note: This will only be reliable when the device pixel scale/ratio is
     // fixed (e.g. when drawing to context backed by an ImageBuffer).
@@ skipping 194 matching lines @@
         DrawLooperBuilder::ShadowTransformMode = DrawLooperBuilder::ShadowRespectsTransforms,
         DrawLooperBuilder::ShadowAlphaMode = DrawLooperBuilder::ShadowRespectsAlpha, ShadowMode = DrawShadowAndForeground);
     void clearShadow() { clearDrawLooper(); }
 
     // It is assumed that this draw looper is used only for shadows
     // (i.e. a draw looper is set if and only if there is a shadow).
     // The builder passed into this method will be destroyed.
     void setDrawLooper(PassOwnPtr<DrawLooperBuilder>);
     void clearDrawLooper();
 
+    // It is assumed that this image filter is used only for shadows
+    // (i.e. an image filter is set if and only if there is a shadow).
+    void setImageFilter(PassRefPtr<SkImageFilter>);

[Stephen White, 2014/10/23 01:45:47]

Make these private?

[Justin Novosad, 2014/10/23 02:29:21]

Yes, and while you are at it, make the drawLooper methods above private. We
don't want external code to call these directly because it would conflict with
the state that is set by setShadow.

[sugoi1, 2014/10/23 17:43:17]

Can't, they're also use for text shadows.

[sugoi1, 2014/10/23 17:43:17]

Done.

+    void clearImageFilter();
+
     void drawFocusRing(const Vector<IntRect>&, int width, int offset, const Color&);
     void drawFocusRing(const Path&, int width, int offset, const Color&);
 
     enum Edge {
         NoEdge = 0,
         TopEdge = 1 << 1,
         RightEdge = 1 << 2,
         BottomEdge = 1 << 3,
         LeftEdge = 1 << 4
     };
@@ skipping 31 matching lines @@
 
     void beginAnnotation(const AnnotationList&);
     void endAnnotation();
 
     void preparePaintForDrawRectToRect(
         SkPaint*,
         const SkRect& srcRect,
         const SkRect& destRect,
         CompositeOperator,
         WebBlendMode,
+        bool isOpaque,
         bool isLazyDecoded = false,
         bool isDataComplete = true) const;
 
     static int focusRingOutsetExtent(int offset, int width)
     {
         return focusRingOutset(offset) + (focusRingWidth(width) + 1) / 2;
     }
 
 private:
     const GraphicsContextState* immutableState() const { return m_paintState; }
@@ skipping 101 matching lines @@
     bool m_accelerated : 1;
     bool m_isCertainlyOpaque : 1;
     bool m_printing : 1;
     bool m_antialiasHairlineImages : 1;
     bool m_shouldSmoothFonts : 1;
 };
 
 } // namespace blink
 
 #endif // GraphicsContext_h