Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669113002: DevTools: replace mouseout with mouseleave where possible. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: replace mouseout with mouseleave where possible. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184189

Patch Set 1 #

Total comments: 1

Patch Set 2 : +mouseenter #

Patch Set 3 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -24 lines) Patch
M Source/devtools/front_end/components/DOMPresentationUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/BreakpointsSidebarPane.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/CountersGraph.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/Layers3DView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/ui/SoftContextMenu.js View 5 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pfeldman
6 years, 2 months ago (2014-10-22 12:38:05 UTC) #2
apavlov
lgtm with a commment https://codereview.chromium.org/669113002/diff/1/Source/devtools/front_end/sources/BreakpointsSidebarPane.js File Source/devtools/front_end/sources/BreakpointsSidebarPane.js (right): https://codereview.chromium.org/669113002/diff/1/Source/devtools/front_end/sources/BreakpointsSidebarPane.js#newcode558 Source/devtools/front_end/sources/BreakpointsSidebarPane.js:558: this._createCategory(WebInspector.UIString("Mouse"), ["click", "dblclick", "mousedown", "mouseup", ...
6 years, 2 months ago (2014-10-22 12:43:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669113002/40001
6 years, 2 months ago (2014-10-22 13:37:20 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 15:24:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 184189

Powered by Google App Engine
This is Rietveld 408576698