Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 6691046: Add -mtls-use-call option to avoid %gs:0 TLS accesses. (Closed)

Created:
9 years, 8 months ago by Roland McGrath
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/git/nacl-gcc@master
Visibility:
Public.

Description

Add -mtls-use-call option to avoid %gs:0 TLS accesses. Adds an option to the 32-bit code generator to match the 64-bit variant's behavior of generating calls to __nacl_read_tp rather than fetches from %gs:0 to begin TLS access sequences. We'll want this for the builds of newlib and libstdc++ that go into the integrated runtime. They have their own uses of TLS, which must be kept separate from the user-side libc's TLS setup. We'll reserve %gs for the user side. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595 Committed: http://git.chromium.org/gitweb/?p=nacl-gcc.git;a=commit;h=3aa84df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M gcc/config.gcc View 1 chunk +1 line, -0 lines 0 comments Download
M gcc/config/i386/i386.c View 1 chunk +1 line, -1 line 0 comments Download
A gcc/config/i386/nacl.opt View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Roland McGrath
9 years, 8 months ago (2011-04-04 22:52:44 UTC) #1
Mark Seaborn
On 4 April 2011 15:52, <mcgrathr@chromium.org> wrote: > Reviewers: mseaborn - please use other, > ...
9 years, 8 months ago (2011-04-05 06:23:44 UTC) #2
eaeltsin
Please, add at least one of (khim@chromium.org, pasko, eaeltsin) to all gnu toolchain code reviews! ...
9 years, 8 months ago (2011-04-05 10:16:10 UTC) #3
Mark Seaborn
On 5 April 2011 03:16, <eaeltsin@google.com> wrote: > Please, add at least one of (khim@chromium.org, ...
9 years, 8 months ago (2011-04-05 15:12:20 UTC) #4
eaeltsin
On 2011/04/05 15:12:20, Mark Seaborn wrote: > On 5 April 2011 03:16, <mailto:eaeltsin@google.com> wrote: > ...
9 years, 8 months ago (2011-04-05 15:37:00 UTC) #5
eaeltsin
Or I didn't get that you need both options (gs and call) for x86-32? On ...
9 years, 8 months ago (2011-04-05 15:42:04 UTC) #6
Mark Seaborn
On 5 April 2011 08:37, <eaeltsin@google.com> wrote: > On 2011/04/05 15:12:20, Mark Seaborn wrote: > ...
9 years, 8 months ago (2011-04-05 16:00:29 UTC) #7
eaeltsin
9 years, 8 months ago (2011-04-05 17:44:35 UTC) #8
lgtm

I'm not happy with having yet another way of building nacl sources... but I
don't want to block the integrated runtime work.

Powered by Google App Engine
This is Rietveld 408576698