Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669053002: [turbofan] split compilation stats off from HStatistics and track high water marks (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] split compilation stats off from HStatistics and track high water marks R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24830

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : add in function names #

Patch Set 12 : make prettier #

Patch Set 13 : #

Patch Set 14 : unify and simplify #

Patch Set 15 : rebase #

Patch Set 16 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+554 lines, -180 lines) Patch
M BUILD.gn View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
A src/compilation-statistics.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +82 lines, -0 lines 0 comments Download
A src/compilation-statistics.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +140 lines, -0 lines 0 comments Download
M src/compiler/pipeline.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 21 chunks +50 lines, -85 lines 0 comments Download
A src/compiler/pipeline-statistics.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +94 lines, -0 lines 0 comments Download
A src/compiler/pipeline-statistics.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +97 lines, -0 lines 1 comment Download
M src/compiler/register-allocator.h View 1 2 3 4 4 chunks +3 lines, -5 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 3 4 10 chunks +35 lines, -65 lines 0 comments Download
M src/compiler/zone-pool.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/zone-pool.cc View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -4 lines 0 comments Download
M src/isolate.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +3 lines, -2 lines 2 comments Download
M src/isolate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +8 lines, -4 lines 0 comments Download
M test/unittests/compiler/zone-pool-unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 7 chunks +17 lines, -12 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcarney
ptal
6 years, 2 months ago (2014-10-22 14:43:13 UTC) #2
Jarin
lgtm. https://codereview.chromium.org/669053002/diff/300001/src/compiler/pipeline-statistics.cc File src/compiler/pipeline-statistics.cc (right): https://codereview.chromium.org/669053002/diff/300001/src/compiler/pipeline-statistics.cc#newcode16 src/compiler/pipeline-statistics.cc:16: scope_.Reset(new ZonePool::StatsScope(pipeline_stats->zone_pool_)); This dynamic allocation is a bit ...
6 years, 2 months ago (2014-10-23 09:03:02 UTC) #3
dcarney
6 years, 2 months ago (2014-10-23 09:14:56 UTC) #4
Message was sent while issue was closed. 
Committed patchset #16 (id:300001) manually as 24830 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698