Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 669043002: DevTools: Fix the way search works when switching between editor tabs. (Closed)

Created:
6 years, 2 months ago by vsevik
Modified:
6 years, 2 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix the way search works when switching between editor tabs. We should perform the search in the newly selected editor after switching tabs. We should also postpone setting selection in the editor to the moment where it has synced its sized, otherwise we mess up the scroll position. BUG=413153 R=lushnikov@chromium.org, lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184257

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+368 lines, -4 lines) Patch
A LayoutTests/inspector/editor/resources/search-me.js View 1 2 1 chunk +265 lines, -0 lines 0 comments Download
A LayoutTests/inspector/editor/text-editor-search-switch-editor.html View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A LayoutTests/inspector/editor/text-editor-search-switch-editor-expected.txt View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M Source/devtools/front_end/components/SearchableView.js View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 3 chunks +14 lines, -0 lines 0 comments Download
M Source/devtools/front_end/source_frame/SourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
vsevik
PTAL
6 years, 2 months ago (2014-10-22 07:46:05 UTC) #1
lushnikov
https://codereview.chromium.org/669043002/diff/20001/Source/devtools/front_end/components/SearchableView.js File Source/devtools/front_end/components/SearchableView.js (right): https://codereview.chromium.org/669043002/diff/20001/Source/devtools/front_end/components/SearchableView.js#newcode372 Source/devtools/front_end/components/SearchableView.js:372: this._clearSearch(); these three lines are "resetSearch()" essentially
6 years, 2 months ago (2014-10-22 11:12:37 UTC) #2
lushnikov
On 2014/10/22 11:12:37, lushnikov wrote: > https://codereview.chromium.org/669043002/diff/20001/Source/devtools/front_end/components/SearchableView.js > File Source/devtools/front_end/components/SearchableView.js (right): > > https://codereview.chromium.org/669043002/diff/20001/Source/devtools/front_end/components/SearchableView.js#newcode372 > ...
6 years, 2 months ago (2014-10-22 11:14:30 UTC) #3
lushnikov
lgtm
6 years, 2 months ago (2014-10-22 11:31:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669043002/40001
6 years, 2 months ago (2014-10-23 07:28:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33224)
6 years, 2 months ago (2014-10-23 09:21:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669043002/40001
6 years, 2 months ago (2014-10-23 10:52:59 UTC) #10
vsevik
6 years, 2 months ago (2014-10-23 11:53:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 184257 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698