Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669033002: [Invalidation Tracking] Include DescendantInvalidationSet id in trace events (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
caseq, pdr., rune
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, rwlbuis, rune+blink, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Invalidation Tracking] Include DescendantInvalidationSet id in trace events This CL adds DescendantInvalidationSet "id" field in invalidation tracking trace events. This id will be used to join ScheduleStyleInvalidation events and StyleInvalidatorInvalidation events in devtools. ScheduleStyleInvalidation events are to be added in a separate CL: https://crrev.com/664033002 BUG=410701 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M Source/core/css/invalidation/DescendantInvalidationSet.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
kouhei (in TOK)
Would you take a look?
6 years, 2 months ago (2014-10-22 05:03:07 UTC) #2
rune
On 2014/10/22 at 05:03:07, kouhei wrote: > Would you take a look? core/css lgtm
6 years, 2 months ago (2014-10-22 07:09:51 UTC) #3
kouhei (in TOK)
caseq, pdr: Would you approve core/inspector? > core/css lgtm Thanks!
6 years, 2 months ago (2014-10-22 07:13:02 UTC) #4
pdr.
lgtm
6 years, 2 months ago (2014-10-22 17:16:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669033002/1
6 years, 2 months ago (2014-10-22 17:17:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/14618)
6 years, 2 months ago (2014-10-22 17:31:30 UTC) #9
pdr.
On 2014/10/22 at 17:31:30, commit-bot wrote: > Try jobs failed on following builders: > android_chromium_gn_compile_rel ...
6 years, 2 months ago (2014-10-22 17:43:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669033002/1
6 years, 2 months ago (2014-10-22 17:43:54 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 19:14:50 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184213

Powered by Google App Engine
This is Rietveld 408576698