Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 669023002: Disable mojo_shell download hook temporarily (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years ago
Reviewers:
abarth-chromium
CC:
chromium-reviews, aa1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable mojo_shell download hook temporarily Bug reported by aa@. Will investigate before re-enabling. TBR=abarth@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M DEPS View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jamesr
Error message for posterity: ______ running '/usr/bin/python src/mojo/public/tools/download_shell_binary.py' in '/usr/local/google/home/aa/chrome' Failure: Failed to exchange refresh ...
6 years, 2 months ago (2014-10-22 04:58:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/669023002/1
6 years, 2 months ago (2014-10-22 04:59:48 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 05:54:50 UTC) #5
Failed to apply patch for DEPS:
While running git apply --index -3 -p1;
  error: patch failed: DEPS:748
  Falling back to three-way merge...
  Applied patch to 'DEPS' with conflicts.
  U DEPS

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
0af0bba270190816d88f1e8a6081fc1fb2a902b6..a4dcb3a1fadfd123699db1ba2dee906bd3b1217f
100644
--- a/DEPS
+++ b/DEPS
@@ -748,11 +748,12 @@ hooks = [
     ],
   },
   # Pull the mojo_shell binary, used for mojo development
-  {
-    'name': 'download_mojo_shell',
-    'pattern': '',
-    'action': [ 'python', 'src/mojo/public/tools/download_shell_binary.py' ],
-  },
+# TODO(jamesr): Figure out auth issues and re-enable.
+#{
+#    'name': 'download_mojo_shell',
+#    'pattern': '',
+#    'action': [ 'python', 'src/mojo/public/tools/download_shell_binary.py' ],
+#  },
   {
     # A change to a .gyp, .gypi, or to GYP itself should run the generator.
     'name': 'gyp',

Powered by Google App Engine
This is Rietveld 408576698