sync: hook up ServerConnectionManager <> SyncerThread2 and tie up more loose ends

chrome/browser/sync/engine/syncer.cc

Index: chrome/browser/sync/engine/syncer.cc
diff --git a/chrome/browser/sync/engine/syncer.cc b/chrome/browser/sync/engine/syncer.cc
index ac206006c51e6e19be51ee5e107c501df4c15c71..2f24ee1b27706d7ffedd965076f1bf258e2efce8 100644
--- a/chrome/browser/sync/engine/syncer.cc
+++ b/chrome/browser/sync/engine/syncer.cc
@@ -271,9 +271,6 @@ void Syncer::SyncShare(sessions::SyncSession* session,
         break;
       }
       case SYNCER_END: {
-        VLOG(1) << "Syncer End";
-        SyncerEndCommand syncer_end_command;
-        syncer_end_command.Execute(session);
         break;
       }
       default:
@@ -284,11 +281,9 @@ void Syncer::SyncShare(sessions::SyncSession* session,
     current_step = next_step;
   }
 
-  // Always send out a cycle ended notification, regardless of end-state.
-  SyncEngineEvent event(SyncEngineEvent::SYNC_CYCLE_ENDED);
-  sessions::SyncSessionSnapshot snapshot(session->TakeSnapshot());
-  event.snapshot = &snapshot;
-  session->context()->NotifyListeners(event);
+  VLOG(1) << "Syncer End";
+  SyncerEndCommand syncer_end_command;
+  syncer_end_command.Execute(session);
   return;
 }