sync: hook up ServerConnectionManager <> SyncerThread2 and tie up more loose ends

chrome/browser/sync/engine/all_status.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/all_status.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/port.h"
@@ skipping 109 matching lines @@
 }
 
 void AllStatus::HandleServerConnectionEvent(
     const ServerConnectionEvent& event) {
   if (ServerConnectionEvent::STATUS_CHANGED == event.what_happened) {
     ScopedStatusLock lock(this);
     status_.server_up = IsGoodReplyFromServer(event.connection_code);
     status_.server_reachable = event.server_reachable;
 
     if (event.connection_code == HttpResponse::SERVER_CONNECTION_OK) {
-      if (!status_.authenticated) {
-        status_ = CreateBlankStatus();
-      }
       status_.authenticated = true;
     } else {
       status_.authenticated = false;
     }
   }
 }
 
 sync_api::SyncManager::Status AllStatus::status() const {
   base::AutoLock lock(mutex_);
   return status_;
@@ skipping 18 matching lines @@
     : allstatus_(allstatus) {
   allstatus->mutex_.Acquire();
 }
 
 ScopedStatusLock::~ScopedStatusLock() {
   allstatus_->CalcStatusChanges();
   allstatus_->mutex_.Release();
 }
 
 }  // namespace browser_sync