Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 6690006: Improve GVN dependency tracking by adding parameters to certain flags.
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« src/hydrogen-instructions.h ('K') | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 547 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 // Verify that instructions that may have side-effects are followed 558 // Verify that instructions that may have side-effects are followed
559 // by a simulate instruction. 559 // by a simulate instruction.
560 if (HasSideEffects() && !IsOsrEntry()) { 560 if (HasSideEffects() && !IsOsrEntry()) {
561 ASSERT(next()->IsSimulate()); 561 ASSERT(next()->IsSimulate());
562 } 562 }
563 563
564 // Verify that instructions that can be eliminated by GVN have overridden 564 // Verify that instructions that can be eliminated by GVN have overridden
565 // HValue::DataEquals. The default implementation is UNREACHABLE. We 565 // HValue::DataEquals. The default implementation is UNREACHABLE. We
566 // don't actually care whether DataEquals returns true or false here. 566 // don't actually care whether DataEquals returns true or false here.
567 if (CheckFlag(kUseGVN)) DataEquals(this); 567 if (CheckFlag(kUseGVN)) DataEquals(this);
568
569 if (CheckFlag(kHasGVNParameter)) GetGVNParameter();
568 } 570 }
569 #endif 571 #endif
570 572
571 573
572 void HUnaryCall::PrintDataTo(StringStream* stream) { 574 void HUnaryCall::PrintDataTo(StringStream* stream) {
573 value()->PrintNameTo(stream); 575 value()->PrintNameTo(stream);
574 stream->Add(" "); 576 stream->Add(" ");
575 stream->Add("#%d", argument_count()); 577 stream->Add("#%d", argument_count());
576 } 578 }
577 579
(...skipping 929 matching lines...) Expand 10 before | Expand all | Expand 10 after
1507 1509
1508 1510
1509 void HCheckPrototypeMaps::Verify() { 1511 void HCheckPrototypeMaps::Verify() {
1510 HInstruction::Verify(); 1512 HInstruction::Verify();
1511 ASSERT(HasNoUses()); 1513 ASSERT(HasNoUses());
1512 } 1514 }
1513 1515
1514 #endif 1516 #endif
1515 1517
1516 } } // namespace v8::internal 1518 } } // namespace v8::internal
OLDNEW
« src/hydrogen-instructions.h ('K') | « src/hydrogen-instructions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698