Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 6690001: Add flashmap (fmap) support to Flashrom (Closed)

Created:
9 years, 9 months ago by Nick Sanders
Modified:
9 years, 7 months ago
Reviewers:
dhendrix, Benson Leung
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add flashmap (fmap) support to Flashrom This adds flashmap parsing to Flashrom. If an fmap data structure is found, entries will be added to flashrom's internal rom layout. BUG=chromium-os:115 TEST=Tested on Alex Testing methodology is similar to what was used in the -i argument patch (git hash d0ea9e), except now fmap data was present in the original bios image: - Partial write test (automated script) - Manual partial reads test by reading 4K chunks from ROM and comparing against original BIOS image file and also inspecting the chip-sized file. - Ensure final chip-size image is generated properly by omitting :file from one of the -i arguments. - Full read if no -i options are used when fmap is present - Entire chip written if no -i option is specified and fmap is present. Same holds true if a layout file is specified by no regions are included. A command like "flashrom -w bios.bin" or "flashrom -l layout.txt -w bios.bin" will consistently write the full image to ROM. - Specifying a non-existent region caused flashrom to fail (expected result). TODO: Automate all of the above. Review URL: http://codereview.chromium.org/6025013 (cherry picked from commit 6d62d75b8b58a1a75a7d98d4aa22022eee546bbe) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=4721916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -7 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
M flash.h View 1 chunk +1 line, -0 lines 0 comments Download
M flashrom.c View 1 chunk +6 lines, -0 lines 0 comments Download
A fmap.h View 1 chunk +88 lines, -0 lines 0 comments Download
A fmap.c View 1 chunk +108 lines, -0 lines 0 comments Download
M layout.c View 5 chunks +67 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nick Sanders
9 years, 9 months ago (2011-03-13 09:25:35 UTC) #1
Benson Leung
9 years, 9 months ago (2011-03-13 09:28:07 UTC) #2
On 2011/03/13 09:25:35, Nick Sanders wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698