Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: mojo/services/network/udp_socket_impl.cc

Issue 668993002: Mojo UDP: add a client-side wrapper which handles the client<->server buffering for users. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/network/BUILD.gn ('k') | mojo/services/network/udp_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/network/udp_socket_impl.cc
diff --git a/mojo/services/network/udp_socket_impl.cc b/mojo/services/network/udp_socket_impl.cc
index e39d4a700999600129e14065f7a9576acffcfe0d..72d086e8228bb4ffcc5b9cedb43777b01ec89dc5 100644
--- a/mojo/services/network/udp_socket_impl.cc
+++ b/mojo/services/network/udp_socket_impl.cc
@@ -82,6 +82,11 @@ void UDPSocketImpl::Bind(
bound_ = true;
callback.Run(MakeNetworkError(net::OK), bound_addr.Pass());
+
+ if (remaining_recv_slots_ > 0) {
+ DCHECK(!recvfrom_buffer_.get());
+ DoRecvFrom();
+ }
}
void UDPSocketImpl::SetSendBufferSize(
@@ -138,7 +143,7 @@ void UDPSocketImpl::NegotiateMaxPendingSendRequests(
}
void UDPSocketImpl::ReceiveMore(uint32_t datagram_number) {
- if (!bound_ || datagram_number == 0)
+ if (datagram_number == 0)
return;
if (std::numeric_limits<size_t>::max() - remaining_recv_slots_ <
datagram_number) {
@@ -147,7 +152,7 @@ void UDPSocketImpl::ReceiveMore(uint32_t datagram_number) {
remaining_recv_slots_ += datagram_number;
- if (!recvfrom_buffer_.get()) {
+ if (bound_ && !recvfrom_buffer_.get()) {
DCHECK_EQ(datagram_number, remaining_recv_slots_);
DoRecvFrom();
}
« no previous file with comments | « mojo/services/network/BUILD.gn ('k') | mojo/services/network/udp_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698