Chromium Code Reviews| Index: chrome/browser/resources/ntp4/new_tab.js |
| diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js |
| index 50a58dceacb7dac9c65e6180152888ceacdc3c6c..020d1f86b9e9e79f84fc1606a52416b0f3687de7 100644 |
| --- a/chrome/browser/resources/ntp4/new_tab.js |
| +++ b/chrome/browser/resources/ntp4/new_tab.js |
| @@ -299,7 +299,6 @@ cr.define('ntp', function() { |
| startTime = Date.now(); |
| }); |
| - preventDefaultOnPoundLinkClicks(); // From webui/js/util.js. |
| cr.ui.FocusManager.disableMouseFocusOnButtons(); |
| } |
| @@ -463,16 +462,13 @@ cr.define('ntp', function() { |
| var linksBin = $('notificationLinks'); |
| linksBin.textContent = ''; |
| for (var i = 0; i < links.length; i++) { |
| - var link = linksBin.ownerDocument.createElement('div'); |
| + var link = linksBin.ownerDocument.createElement('a', 'action-link'); |
|
aboxhall
2014/10/22 21:33:31
This is a clear improvement!
Dan Beam
2014/10/23 03:05:44
yay!
|
| link.textContent = links[i].text; |
| link.action = links[i].action; |
| link.onclick = function() { |
| this.action(); |
| hideNotification(); |
| }; |
| - link.setAttribute('role', 'button'); |
| - link.setAttribute('tabindex', 0); |
| - link.className = 'link-button'; |
| linksBin.appendChild(link); |
| } |