chrome/browser/resources/history/history.js - Issue 668983004: Add <a is="action-link">, a web component extension of <a> for in-page actions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/history/history.js

Issue 668983004: Add <a is="action-link">, a web component extension of <a> for in-page actions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/downloads/downloads.js ('K') | « chrome/browser/resources/history/history.html ('k') | chrome/browser/resources/history/other_devices.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/history/history.js

diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js

index 6c18a61a5bd88413d3673a357f6123659fb06e2d..b6e2ab7b23c99442cb38d79bec661fcd61b8eadf 100644

--- a/chrome/browser/resources/history/history.js

+++ b/chrome/browser/resources/history/history.js

@@ -1311,8 +1311,7 @@ HistoryView.prototype.getGroupedVisitsDOM_ = function(

var siteDomain = siteDomainRow.appendChild(

createElementWithClassName('div', 'site-domain'));

var siteDomainLink = siteDomain.appendChild(

- createElementWithClassName('button', 'link-button'));

- siteDomainLink.addEventListener('click', function(e) { e.preventDefault(); });

+ document.createElement('a', 'action-link'));

siteDomainLink.textContent = domain;

var numberOfVisits = createElementWithClassName('span', 'number-visits');

var domainElement = document.createElement('span');

@@ -1604,7 +1603,7 @@ var focusGridColumnSelector = [

'.title a',

'.drop-down',

'.domain-checkbox',

- '.link-button',

+ '[is="action-link"]',

].join(', ');

/** @private */