Enable chrome.mdns for Chrome Apps

chrome/browser/extensions/api/mdns/mdns_api.cc

Index: chrome/browser/extensions/api/mdns/mdns_api.cc
diff --git a/chrome/browser/extensions/api/mdns/mdns_api.cc b/chrome/browser/extensions/api/mdns/mdns_api.cc
index 572ae1eec7b08e50906f96f94aeda0314b75d1c0..6384ba7c5b57aa891a627200ea700c280c9c975e 100644
--- a/chrome/browser/extensions/api/mdns/mdns_api.cc
+++ b/chrome/browser/extensions/api/mdns/mdns_api.cc
@@ -15,21 +15,6 @@ namespace extensions {
 
 namespace mdns = api::mdns;
 
-namespace {
-
-// Whitelisted mDNS service types.
-const char kCastServiceType[] = "_googlecast._tcp.local";
-const char kPrivetServiceType[] = "_privet._tcp.local";
-const char kTestServiceType[] = "_testing._tcp.local";
-
-bool IsServiceTypeWhitelisted(const std::string& service_type) {
-  return service_type == kCastServiceType ||
-         service_type == kPrivetServiceType ||
-         service_type == kTestServiceType;
-}
-
-}  // namespace
-
 MDnsAPI::MDnsAPI(content::BrowserContext* context) : browser_context_(context) {
   DCHECK(browser_context_);
   EventRouter::Get(context)
@@ -114,13 +99,11 @@ void MDnsAPI::UpdateMDnsListeners(const EventListenerInfo& details) {
   DnsSdRegistry* registry = dns_sd_registry();
   for (std::set<std::string>::iterator it = added_service_types.begin();
        it != added_service_types.end(); ++it) {
-    if (IsServiceTypeWhitelisted(*it))
-      registry->RegisterDnsSdListener(*it);
+    registry->RegisterDnsSdListener(*it);

[mark a. foltz, 2014/10/31 06:29:15]

To preserve existing behavior, I think extensions should be limited by the
existing whitelist as far as what services they can listen for.  We can discuss
as part of the API review if this can be relaxed. 

However, this would require some refactoring as the event filtering is currently
done only by service type and not the type of listener (extension vs. platform
app).

[Red Daly, 2014/11/17 22:50:01]

Done.

   }
   for (std::set<std::string>::iterator it = removed_service_types.begin();
        it != removed_service_types.end(); ++it) {
-    if (IsServiceTypeWhitelisted(*it))
-      registry->UnregisterDnsSdListener(*it);
+    registry->UnregisterDnsSdListener(*it);
   }
 
   service_types_ = new_service_types;