Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issue 668943003: ozone: evdev: Drop unmapped key events (Closed)

Created:
6 years, 2 months ago by spang
Modified:
6 years, 2 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Drop unmapped key events In particular BTN_* events for the touchpad should not be dispatched as keypresses. So just filter any presses that aren't mapped. BUG=425617 TEST=manual on link_freon, events_unittests Committed: https://crrev.com/40efb7c79d00766cea2f7e40eb2432765189c6a2 Cr-Commit-Position: refs/heads/master@{#300559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M ui/events/ozone/evdev/key_event_converter_evdev_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/keyboard_evdev.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
6 years, 2 months ago (2014-10-21 17:56:53 UTC) #2
kpschoedel
lgtm
6 years, 2 months ago (2014-10-21 18:02:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668943003/1
6 years, 2 months ago (2014-10-21 20:19:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 22:28:36 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 22:29:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40efb7c79d00766cea2f7e40eb2432765189c6a2
Cr-Commit-Position: refs/heads/master@{#300559}

Powered by Google App Engine
This is Rietveld 408576698