Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 668933002: Chromecast browser test: use CastContentWindow for test lifetime. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
lcwu1, GusFernandez
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast browser test: use CastContentWindow for test lifetime. R=lcwu@chromium.org,gusfernandez@chromium.org BUG=None Committed: https://crrev.com/ccd4ab466fa8fb28d6fef9b22c8e4bcb57dcab68 Cr-Commit-Position: refs/heads/master@{#300554}

Patch Set 1 #

Patch Set 2 : fix include path #

Total comments: 2

Patch Set 3 : minor formatting nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M chromecast/browser/test/chromecast_browser_test.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chromecast/browser/test/chromecast_browser_test.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
gunsch
6 years, 2 months ago (2014-10-21 16:27:33 UTC) #1
lcwu1
LGTM % minor formatting nit. https://codereview.chromium.org/668933002/diff/20001/chromecast/browser/test/chromecast_browser_test.h File chromecast/browser/test/chromecast_browser_test.h (right): https://codereview.chromium.org/668933002/diff/20001/chromecast/browser/test/chromecast_browser_test.h#newcode18 chromecast/browser/test/chromecast_browser_test.h:18: class CastContentWindow; While style ...
6 years, 2 months ago (2014-10-21 19:34:56 UTC) #2
gunsch
https://codereview.chromium.org/668933002/diff/20001/chromecast/browser/test/chromecast_browser_test.h File chromecast/browser/test/chromecast_browser_test.h (right): https://codereview.chromium.org/668933002/diff/20001/chromecast/browser/test/chromecast_browser_test.h#newcode18 chromecast/browser/test/chromecast_browser_test.h:18: class CastContentWindow; On 2014/10/21 19:34:56, lcwu1 wrote: > While ...
6 years, 2 months ago (2014-10-21 19:36:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668933002/40001
6 years, 2 months ago (2014-10-21 19:37:22 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-21 20:53:22 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 20:54:02 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ccd4ab466fa8fb28d6fef9b22c8e4bcb57dcab68
Cr-Commit-Position: refs/heads/master@{#300554}

Powered by Google App Engine
This is Rietveld 408576698