Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/apps/app_browsertest_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/app_browsertest.cc
diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc
index 83f36cfc03c3b404599fbaa6791b8aa43801e98a..d441c15df4b8227e3e2448dc4f115214c1e67be8 100644
--- a/chrome/browser/apps/app_browsertest.cc
+++ b/chrome/browser/apps/app_browsertest.cc
@@ -78,9 +78,8 @@ class PlatformAppContextMenu : public RenderViewContextMenu {
protected:
// RenderViewContextMenu implementation.
- virtual bool GetAcceleratorForCommandId(
- int command_id,
- ui::Accelerator* accelerator) override {
+ bool GetAcceleratorForCommandId(int command_id,
+ ui::Accelerator* accelerator) override {
return false;
}
};
@@ -97,9 +96,9 @@ class TabsAddedNotificationObserver
observations_(observations) {
}
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override {
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override {
observed_tabs_.push_back(
content::Details<WebContents>(details).ptr());
if (observed_tabs_.size() == observations_)
@@ -130,18 +129,15 @@ class ScopedPreviewTestingDelegate : PrintPreviewUI::TestingDelegate {
}
// PrintPreviewUI::TestingDelegate implementation.
- virtual bool IsAutoCancelEnabled() override {
- return auto_cancel_;
- }
+ bool IsAutoCancelEnabled() override { return auto_cancel_; }
// PrintPreviewUI::TestingDelegate implementation.
- virtual void DidGetPreviewPageCount(int page_count) override {
+ void DidGetPreviewPageCount(int page_count) override {
total_page_count_ = page_count;
}
// PrintPreviewUI::TestingDelegate implementation.
- virtual void DidRenderPreviewPage(content::WebContents* preview_dialog)
- override {
+ void DidRenderPreviewPage(content::WebContents* preview_dialog) override {
dialog_size_ = preview_dialog->GetContainerBounds().size();
++rendered_page_count_;
CHECK(rendered_page_count_ <= total_page_count_);
@@ -949,9 +945,9 @@ class CheckExtensionInstalledObserver : public content::NotificationObserver {
};
// NotificationObserver:
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override {
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override {
EXPECT_FALSE(seen_);
seen_ = true;
}
« no previous file with comments | « no previous file | chrome/browser/apps/app_browsertest_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698