components/variations/net/BUILD.gn - Issue 668863002: [Clean up] Move VariationsHttpHeaderProvider into a subdirectory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/variations/net/BUILD.gn

Issue 668863002: [Clean up] Move VariationsHttpHeaderProvider into a subdirectory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add GN dependency on //components/google/core/browser Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("variations_http_provider") {
	jamesr 2014/10/24 00:30:05 this is very stuttery for a GN label. source_set n this is very stuttery for a GN label. source_set names do not have to be globally unique, only their label needs to be. the label for this is //components/variations/net:variations_http_provider which repeats variations. If that's the only thing that this directory will contain, i would call this source_set "net" making the label //components/variations/net or if you will have things other than the http provider, call it something like //components/variations/net:http_provider Ilya Sherman 2014/10/24 00:44:45 Done. I originally chose the name to match the GY Show quoted text On 2014/10/24 00:30:05, jamesr wrote: > this is very stuttery for a GN label. source_set names do not have to be > globally unique, only their label needs to be. the label for this is > > //components/variations/net:variations_http_provider > > which repeats variations. If that's the only thing that this directory will > contain, i would call this source_set "net" making the label > > //components/variations/net > > or if you will have things other than the http provider, call it something like > > //components/variations/net:http_provider Done. I originally chose the name to match the GYP target name, but I agree with you that it's pretty clunky.
	6 sources = [

	7 "variations_http_header_provider.cc",

	8 "variations_http_header_provider.h",

	9 ]

	10

	11 public_deps = [
	jamesr 2014/10/24 00:30:05 collapse this to one line: public_deps = [ "//com collapse this to one line: public_deps = [ "//components/variations" ] Ilya Sherman 2014/10/24 00:44:45 Done. Show quoted text On 2014/10/24 00:30:05, jamesr wrote: > collapse this to one line: > > public_deps = [ "//components/variations" ] Done.
	12 "//components/variations",

	13 ]

	14 deps = [

	15 "//base",

	16 "//components/google/core/browser",

	17 "//components/variations/proto",

	18 "//net",

	19 ]

	20 }

OLD	NEW

« no previous file with comments | « components/variations/DEPS ('k') | components/variations/net/DEPS » ('j') | no next file with comments »