Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 668833003: Make Smart Lock user pod icons work well with ChromeVox. (Closed)

Created:
6 years, 2 months ago by Tim Song
Modified:
6 years, 2 months ago
Reviewers:
Nikita (slow), tbarzic
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make Smart Lock user pod icons work well with ChromeVox. BUG=413779 TEST=manual Committed: https://crrev.com/863d5ee23ee33f5a47036a966f6f346c8f1c3ab0 Cr-Commit-Position: refs/heads/master@{#300736}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : confirmed string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/signin/screenlock_bridge.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/signin/screenlock_bridge.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/login/account_picker/user_pod_row.js View 5 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Tim Song
https://codereview.chromium.org/668833003/diff/20001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/668833003/diff/20001/chrome/app/generated_resources.grd#newcode14758 chrome/app/generated_resources.grd:14758: + Initializing Smart Lock This is still TBD.
6 years, 2 months ago (2014-10-21 01:24:03 UTC) #3
Tim Song
https://codereview.chromium.org/668833003/diff/20001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/668833003/diff/20001/chrome/app/generated_resources.grd#newcode14758 chrome/app/generated_resources.grd:14758: + Initializing Smart Lock On 2014/10/21 01:24:03, Tim Song ...
6 years, 2 months ago (2014-10-21 01:29:55 UTC) #4
tbarzic
lgtm
6 years, 2 months ago (2014-10-21 02:02:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668833003/40001
6 years, 2 months ago (2014-10-21 20:47:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19061)
6 years, 2 months ago (2014-10-21 20:56:23 UTC) #9
Tim Song
+nkostylev for ui/login
6 years, 2 months ago (2014-10-21 22:27:32 UTC) #11
Nikita (slow)
lgtm
6 years, 2 months ago (2014-10-22 10:52:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668833003/40001
6 years, 2 months ago (2014-10-22 18:07:26 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 2 months ago (2014-10-22 20:17:46 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 20:19:00 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/863d5ee23ee33f5a47036a966f6f346c8f1c3ab0
Cr-Commit-Position: refs/heads/master@{#300736}

Powered by Google App Engine
This is Rietveld 408576698