Issue 6688016: web-ui settings: Fix incorrect handling for the Import dialog when no browser...

Issue 6688016: web-ui settings: Fix incorrect handling for the Import dialog when no browser... (Closed)

Created:
9 years, 9 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

web-ui settings: Fix incorrect handling for the Import dialog when no browsers are available. BUG=76335 TEST=Verify that the Import dialog correctly cancels when no browsers are available for import. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78644

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : code review tweaks #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/resources/options/import_data_overlay.js	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

http://codereview.chromium.org/6688016/diff/2001/chrome/browser/resources/options/import_data_overlay.js File chrome/browser/resources/options/import_data_overlay.js (right): http://codereview.chromium.org/6688016/diff/2001/chrome/browser/resources/options/import_data_overlay.js#newcode105 chrome/browser/resources/options/import_data_overlay.js:105: if (ImportDataOverlay.browserProfiles.length > index) s/ImportDataOverlay/this/ ?

9 years, 9 months ago (2011-03-17 21:49:29 UTC) #2

csilv

9 years, 9 months ago (2011-03-17 22:18:28 UTC) #3

LGTM

Expand Messages | Collapse Messages